community/device-mgt-core
1
0
Fork 0
mirror of https://repository.entgra.net/community/device-mgt-core.git synced 2025-10-06 02:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use try with resources for dao layer

Browse Source
This commit is contained in:
pasindu 2024-09-03 09:46:05 +05:30
parent 6d324c084a
commit 87b98a6cb5
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
components/device-mgt/io.entgra.device.mgt.core.device.mgt.core/src/main/java/io/entgra/device/mgt/core/device/mgt/core/operation/mgt/dao/impl/GenericOperationDAOImpl.java
View File

@ -130,11 +130,8 @@ public class GenericOperationDAOImpl implements OperationDAO {
public int updateOperationByDeviceTypeAndInitialStatus(String deiceType, String initialStatus, String requiredStatus) public int updateOperationByDeviceTypeAndInitialStatus(String deiceType, String initialStatus, String requiredStatus)
throws OperationManagementDAOException { throws OperationManagementDAOException {
PreparedStatement stmt = null;
int numOfRecordsUpdated; int numOfRecordsUpdated;
try {
long time = DeviceManagementDAOUtil.getCurrentUTCTime(); long time = DeviceManagementDAOUtil.getCurrentUTCTime();
Connection connection = OperationManagementDAOFactory.getConnection();
String sql = "UPDATE DM_ENROLMENT_OP_MAPPING SET STATUS=?, UPDATED_TIMESTAMP=? WHERE DEVICE_TYPE=?"; String sql = "UPDATE DM_ENROLMENT_OP_MAPPING SET STATUS=?, UPDATED_TIMESTAMP=? WHERE DEVICE_TYPE=?";
@ -144,7 +141,10 @@ public class GenericOperationDAOImpl implements OperationDAO {
sql += " AND STATUS=?"; sql += " AND STATUS=?";
} }
stmt = connection.prepareStatement(sql); try (
Connection connection = OperationManagementDAOFactory.getConnection();
PreparedStatement stmt = connection.prepareStatement(sql)
) {
stmt.setString(1, requiredStatus); stmt.setString(1, requiredStatus);
stmt.setLong(2, time); stmt.setLong(2, time);
stmt.setString(3, deiceType); stmt.setString(3, deiceType);
@ -156,8 +156,6 @@ public class GenericOperationDAOImpl implements OperationDAO {
} catch (SQLException e) { } catch (SQLException e) {
throw new OperationManagementDAOException("Error occurred while update device mapping operation status " + throw new OperationManagementDAOException("Error occurred while update device mapping operation status " +
e.getMessage(), e); e.getMessage(), e);
} finally {
OperationManagementDAOUtil.cleanupResources(stmt);
} }
return numOfRecordsUpdated; return numOfRecordsUpdated;
} }